Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derived branch name default. #143

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix derived branch name default. #143

merged 2 commits into from
May 22, 2024

Conversation

bosschaert
Copy link
Contributor

Description

The branch name is used by the playwright tests to derive the hostname to use. While the current approach works for PRs, it doesn't work when running the playwright tests on the main branch.

The previous default didn't work if the variable had an empty String as value, in which case it should default to main. There was a default in the code, but this doesn't work in this scenario.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The previous default didn't work if the variable had an empty String as
value.
Copy link

aem-code-sync bot commented May 17, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bosschaert bosschaert merged commit 242c050 into main May 22, 2024
4 of 5 checks passed
@bosschaert bosschaert deleted the fix-pw-branchname branch May 22, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants