Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new URL in the browse list for pasted items. #188

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

bosschaert
Copy link
Contributor

@bosschaert bosschaert commented Jul 5, 2024

Description

When pasting a document in a different directory, use the target directory in the item URL.
Currently the source directory is mistakenly in the URL which means that if you open the document, it opens the one in the source, rather than the copy.

Test URLs:
Before: https://da.live/#/da-sites/da-status/bosschae/sub6
After: https://cpypst--da-live--adobe.hlx.live/#/da-sites/da-status/bosschae/sub6

Related Issue

Fixes #176

How Has This Been Tested?

  • In the UI
  • With new unit tests
  • Extended Playwright test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Jul 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jul 5, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert bosschaert marked this pull request as ready for review July 5, 2024 13:31
auniverseaway
auniverseaway previously approved these changes Jul 9, 2024
@bosschaert bosschaert merged commit a803d77 into main Jul 9, 2024
5 of 6 checks passed
@bosschaert bosschaert deleted the cpypst branch July 9, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening resource just copied opens original
2 participants