fix(fastly): Return undefined for dict values of write-only edge dicts #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the value of an edge dictionary value for a write-only dictionary results in an error 400 from the Fastly API, which is correct, but not helpful. Because `readDictItem` always gets the dictionary metadata before reading, we can guard against this error and return a proper response (status: 403, item_value: undefined) fixes #27
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 203 205 +2
=====================================
+ Hits 203 205 +2
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the value of an edge dictionary value for a write-only dictionary results in an error 400
from the Fastly API, which is correct, but not helpful. Because
readDictItemalways gets thedictionary metadata before reading, we can guard against this error and return a proper response
(status: 403, item_value: undefined)
fixes #27
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!