Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

QueryBuilder Params not supported #55

Closed
trieloff opened this issue Jun 12, 2020 · 7 comments · Fixed by #75
Closed

QueryBuilder Params not supported #55

trieloff opened this issue Jun 12, 2020 · 7 comments · Fixed by #75
Assignees
@trieloff
Labels
bug Something isn't working released

Comments

@trieloff
Copy link
Contributor

No description provided.

@trieloff trieloff added the bug Something isn't working label Jun 12, 2020
@tripodsan
Copy link
Contributor

do we really want to support query builder in the content proxy?
I find this a bit dangerous. maybe this should be solved via some kind of stored queries.

@davidnuescheler WDYT?

@trieloff
Copy link
Contributor Author

David requested the feature, I just opened the issue.

@trieloff trieloff self-assigned this Jun 15, 2020
@tripodsan
Copy link
Contributor

LOL

@davidnuescheler
Copy link

i really only want the paging, also because of the response size limit. i agree that query builder params are not necessary (at least for now) and possibly dangerous...
i would probably prefer some more friendly params like limit= and offset=.

trieloff added a commit that referenced this issue Jun 16, 2020
@trieloff
feat(json): add limit and offset parameters for JSON data
b934441 
partial fix for #55
trieloff added a commit to adobe/helix-publish that referenced this issue Jun 16, 2020
@trieloff
feat(content-proxy): pass along querybuilder parameters
c0002f4 
see adobe/helix-content-proxy#55
@trieloff trieloff mentioned this issue Jun 16, 2020
Merged
2 tasks
trieloff pushed a commit that referenced this issue Jun 16, 2020
@semantic-release-bot
chore(release): 1.6.0 [skip ci]
b62e93a 
# [1.6.0](v1.5.10...v1.6.0) (2020-06-16)

### Features

* **json:** add limit and offset parameters for JSON data ([b934441](b934441)), closes [#55](#55)
@davidnuescheler
Copy link

looks great... should this already be working on helix pages?
right now it still seems to ignore the limit and offset as far as i can tell...
https://theblog-adobe.hlx.page/en/query-index.json?limit=5

@trieloff trieloff mentioned this issue Jun 17, 2020
Closed
@trieloff trieloff reopened this Jun 18, 2020
@trieloff
Copy link
Contributor Author

adobe/theblog#213 (comment)

particularly for author pages and sparse topics we may want to revisit the approach, by either using server-sided filters or possibly just produce a "load posts" if the author hasn't written anything in a long time (let's say the last 1000 posts)

This means me need to pass through all hlx_ parameters

trieloff added a commit that referenced this issue Jun 18, 2020
@trieloff
feat(json): enable all querybuilder parameters
f9478c5 
fixes #55
@trieloff trieloff mentioned this issue Jun 18, 2020
Merged
2 tasks
trieloff pushed a commit that referenced this issue Jun 20, 2020
@semantic-release-bot
chore(release): 1.8.0 [skip ci]
be805f6 
# [1.8.0](v1.7.0...v1.8.0) (2020-06-20)

### Features

* **json:** enable all querybuilder parameters ([f9478c5](f9478c5)), closes [#55](#55)
@trieloff
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@trieloff trieloff

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(json): enable all querybuilder parameters adobe/helix-content-proxy
3 participants
@trieloff @tripodsan @davidnuescheler