This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Use Universal Runtime #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whisk-action-builder
|
This PR will trigger a patch release when merged. |
trieloff
commented
Mar 5, 2021
src/index.js
Outdated
| let res; | ||
| if (/^multipart\/formdata|application\/x-www-form-urlencoded/.test(request.headers.get('content-type'))) { | ||
| context.log.info('Getting parameters from formdata'); | ||
| const data = await request.formData(); |
There was a problem hiding this comment.
@stefan-guggisberg I'm getting an error here:
"message":"Something went wrong TypeError: request.formData is not a function\n at setupLogger (/var/task/index.js:476651:34)\n at /var/task/index.js:15760:12\n at /var/task/index.js:16173:30\n at /var/task/index.js:16129:12\n at /var/task/index.js:39796:13\n at Namespace.run (/var/task/index.js:39775:5)\n at Namespace.runAndReturn (/var/task/index.js:39795:8)\n at wrap (/var/task/index.js:16112:24)\n at /var/task/index.js:16228:23\n at Runtime.lambda [as handler] (/var/task/index.js:3060:28)"
There was a problem hiding this comment.
yes, that's documented: https://github.com/adobe/helix-fetch/blob/main/README.md#about
Response.formData()is not implemented.
Feel free to create an issue if you need it.
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 195 195
=========================================
Hits 195 195 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.