Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

properly propagate error in action response #238

Merged
merged 1 commit into from
Apr 12, 2019
Merged

properly propagate error in action response #238

merged 1 commit into from
Apr 12, 2019

Conversation

stefan-guggisberg
Copy link
Contributor

fixes #237

@ghost
Copy link

ghost commented Apr 5, 2019

There were the following issues with this Pull Request

  • Commit: b8427c8
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@codecov
Copy link

codecov bot commented Apr 5, 2019 •
edited
Loading

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #238   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          39     39           
  Lines         951    952    +1     
  Branches      198    199    +1     
=====================================
+ Hits          951    952    +1
Impacted Files Coverage Δ
src/utils/openwhisk.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f23b204...c319f17. Read the comment docs.

tripodsan
tripodsan reviewed Apr 5, 2019
View reviewed changes
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's correct :-) can you also add tests that trigger this kind of errors?

stefan-guggisberg added a commit that referenced this pull request Apr 6, 2019
@stefan-guggisberg
test: added tests that verify proper error propagation to action resp…
521f0c7 
…onse #238

#238
@ghost
Copy link

ghost commented Apr 6, 2019

There were the following issues with this Pull Request

  • Commit: b8427c8
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@stefan-guggisberg
Copy link
Contributor Author

@tripodsan added tests in 521f0c7

@stefan-guggisberg stefan-guggisberg self-assigned this Apr 6, 2019
@ghost
Copy link

ghost commented Apr 12, 2019

There were the following issues with this Pull Request

  • Commit: b8427c8
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@tripodsan tripodsan merged commit c680eed into master Apr 12, 2019
@tripodsan tripodsan deleted the issue_237 branch April 12, 2019 02:44
trieloff pushed a commit that referenced this pull request Apr 12, 2019
@semantic-release-bot
chore(release): 1.3.2 [skip ci]
bd7d40b 
## [1.3.2](v1.3.1...v1.3.2) (2019-04-12)

### Bug Fixes

* **openwhisk:** properly propagate error in action response ([#238](#238)) ([c680eed](c680eed)), closes [#237](#237)
@trieloff
Copy link
Contributor

🎉 This PR is included in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

ramboz pushed a commit that referenced this pull request Apr 15, 2019
@stefan-guggisberg @ramboz
fix(openwhisk): properly propagate error in action response (#238)
a9e5c48 
fixes #237
ramboz pushed a commit that referenced this pull request Apr 15, 2019
@semantic-release-bot @ramboz
chore(release): 1.3.2 [skip ci]
b7ccd37 
## [1.3.2](v1.3.1...v1.3.2) (2019-04-12)

### Bug Fixes

* **openwhisk:** properly propagate error in action response ([#238](#238)) ([c680eed](c680eed)), closes [#237](#237)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tripodsan tripodsan tripodsan left review comments

@kptdobe kptdobe kptdobe approved these changes

@trieloff trieloff Awaiting requested review from trieloff

Assignees

@stefan-guggisberg stefan-guggisberg

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime errors not returned in action response
4 participants
@stefan-guggisberg @trieloff @kptdobe @tripodsan