Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Add pipeline processing timing information #333

Closed
tripodsan opened this issue May 21, 2019 · 4 comments · Fixed by #334
Closed

Add pipeline processing timing information #333

tripodsan opened this issue May 21, 2019 · 4 comments · Fixed by #334
Assignees
@tripodsan
Labels
released

Comments

@tripodsan
Copy link
Contributor

suggest to record the overall and per-step processing time and report in the log and also include in a response header.

https://w3c.github.io/server-timing/#the-server-timing-header-field

eg:

Server-Timing: p0;dur=53, p1;dur=47.2, p2;dur=47.2, ....
Server-Timing: total;dur=123.4
@tripodsan tripodsan self-assigned this May 21, 2019
@tripodsan
Copy link
Contributor Author

Example:

Server-Timing: p00;dur=59.755027;desc=fetch ,p01;dur=9.509783;desc=parseMarkdown ,p02;dur=2.042807;desc=parseFrontmatter ,p03;dur=1.459516;desc=find ,p04;dur=6.766895;desc=reformat ,p05;dur=2.553625;desc=split ,p06;dur=4.378436;desc=getmetadata ,p07;dur=1.396577;desc=selectstrain ,p08;dur=1.136908;desc=selecttest ,p09;dur=29.395106;desc=html ,p10;dur=1.238519;desc=undef ,p11;dur=1.79802;desc=transformer ,p12;dur=4.396189;desc=once ,p13;dur=1.45282;desc=setmime ,p14;dur=1.314855;desc=cache ,p15;dur=1.708031;desc=key ,p16;dur=1.558716;desc=debug ,p17;dur=22.07377;desc=tohast ,p18;dur=3.046843;desc=rewrite ,p19;dur=4.639235;desc=addHeaders ,p20;dur=4.207381;desc=stringify ,p21;dur=2.531735;desc=flag ,p22;dur=0.20747;desc=report
Server-Timing: total;dur=217.524699

image

tripodsan added a commit that referenced this issue May 21, 2019
@tripodsan
feat(pipe): add timing information and clean up function name reporting
05a7c85 
fixes #333
@tripodsan tripodsan mentioned this issue May 21, 2019
Merged
tripodsan added a commit that referenced this issue May 21, 2019
@tripodsan
feat(pipe): add timing information and clean up function name reporting
b96467c 
fixes #333
@tripodsan
Copy link
Contributor Author

tripodsan commented May 21, 2019 •
edited
Loading

@trieloff @davidnuescheler

here's the timing of a deployed action:
https://www.99productrules.com/index.html

image

same page a bit later:

image

(I guess, the .md was cached by github this time)

@bdelacretaz
Copy link

There might be a synergy between this and @kptdobe's work on dumping the request sequence in graphical form - being able to drill down from the overall request sequence to the pipeline details as a sequence diagram with timings would be great!

tripodsan added a commit that referenced this issue May 27, 2019
@tripodsan
feat(pipe): add timing information and clean up function name reporti…
bf6c779 
…ng (#334)

fixes #333
adobe-bot pushed a commit that referenced this issue May 27, 2019
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
4998fb4 
# [2.1.0](v2.0.0...v2.1.0) (2019-05-27)

### Features

* **pipe:** add timing information and clean up function name reporting ([#334](#334)) ([bf6c779](bf6c779)), closes [#333](#333)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tripodsan tripodsan

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pipe): add timing information and clean up function name reporting adobe/helix-pipeline
3 participants
@bdelacretaz @tripodsan @adobe-bot