Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

improve vdom generator performance #336

Closed
tripodsan opened this issue May 22, 2019 · 2 comments
Closed

improve vdom generator performance #336

tripodsan opened this issue May 22, 2019 · 2 comments
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

tripodsan commented May 22, 2019 •
edited
Loading

  • separate to the toHTAST step completely
  • don't reparse HTML generated by the handlers
  • avoid toHtml/parseHTML rountripds
  • generate jsdom or hast directly in the handlers
@tripodsan tripodsan added the bug Something isn't working label May 22, 2019
@tripodsan tripodsan self-assigned this May 29, 2019
@tripodsan tripodsan mentioned this issue May 29, 2019
Merged
@tripodsan
Copy link
Contributor Author

tripodsan commented May 30, 2019 •
edited
Loading

some key measurements with a 23k markdown:

md-2-html once reparse stringify
before 44ms 23ms 20s 2ms
after 27ms 23ms 32ms 2ms
  • Once the htlengine directly outputs JSDOM, the reparse should drop to 0ms.
  • using a direct mdast-to-jsdom approach in md2html might also reduce this time ever further.

@tripodsan tripodsan mentioned this issue Jun 6, 2019
Closed
adobe-bot pushed a commit that referenced this issue Jun 6, 2019
@semantic-release-bot
chore(release): 2.4.0 [skip ci]
17dd73c 
# [2.4.0](v2.3.0...v2.4.0) (2019-06-06)

### Features

* **pipe:** use jsdom everywhere ([479cc8a](479cc8a)), closes [#337](#337) [#336](#336)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tripodsan @adobe-bot