-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add release history #397
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Nothing critical in my review, just some suggestions.
PS: I like the colored release boxes. They look a bit like cards on mobile - should we turn them into a card grid on desktop?
control.append(label); | ||
controls.append(control); | ||
control.addEventListener('click', () => { | ||
cb.checked = !cb.checked; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we push selected filters to the hash
(if not 'all') to create sticky URLs?
const releases = document.createElement('div'); | ||
const controls = document.createElement('div'); | ||
controls.classList.add('releases-controls'); | ||
Object.keys(displayNames).forEach((repo) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add an 'all' option at the beginning
Co-authored-by: Raphael Wegmueller <github@rofe.com>
|
@rofe i merged it... happy to look at more items later. personally i think that one of the best features would be the |
https://release-history--helix-website--adobe.hlx.live/docs/release-history
vs.
https://main--helix-website--adobe.hlx.live/docs/release-history