Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release history #397

Merged
merged 4 commits into from
Oct 21, 2023
Merged

feat: add release history #397

merged 4 commits into from
Oct 21, 2023

Conversation

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 20, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 20, 2023

Page Scores Audits Google
/docs/release-history PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 20, 2023

Page Scores Audits Google
/docs/release-history PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 20, 2023

Page Scores Audits Google
/docs/release-history PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@rofe rofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Nothing critical in my review, just some suggestions.

PS: I like the colored release boxes. They look a bit like cards on mobile - should we turn them into a card grid on desktop?

blocks/releases/releases.js Outdated Show resolved Hide resolved
control.append(label);
controls.append(control);
control.addEventListener('click', () => {
cb.checked = !cb.checked;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we push selected filters to the hash (if not 'all') to create sticky URLs?

const releases = document.createElement('div');
const controls = document.createElement('div');
controls.classList.add('releases-controls');
Object.keys(displayNames).forEach((repo) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an 'all' option at the beginning

Co-authored-by: Raphael Wegmueller <github@rofe.com>
@aem-code-sync
Copy link

aem-code-sync bot commented Oct 21, 2023

Page Scores Audits Google
/docs/release-history PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@davidnuescheler davidnuescheler merged commit 0849f27 into main Oct 21, 2023
2 of 3 checks passed
@davidnuescheler davidnuescheler deleted the release-history branch October 21, 2023 17:02
@davidnuescheler
Copy link
Contributor Author

davidnuescheler commented Oct 21, 2023

@rofe i merged it... happy to look at more items later. personally i think that one of the best features would be the # link we have on the rest of the docs, feel free to add that if you have some cycles at some point... or i guess the first time we want to point someone to a specific release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants