Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow transient compilation, without touching the file system #3

Merged
merged 2 commits into from
Jun 21, 2018

Conversation

trieloff
Copy link
Contributor

  • instead of forcing to write a file, introduces a new compileTransient method, which returns a string

- instead of forcing to write a file, introduces a new compileTransient method, which returns a string
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically ok, but I don't like the name transient.
other options:

  • just return the string in the normal compile function and handle the save somewhere else
  • maybe add compileToFile()

@tripodsan
Copy link
Contributor

tripodsan commented Jun 21, 2018

btw, why would this fix adobe/parcel-plugin-htl#1 ?

@trieloff
Copy link
Contributor Author

I didn't want to break compatibility for compile. I can change the name of transientCompile into compileToString, add a compileToFile and make compile an alias for compileToFile

@trieloff trieloff merged commit 4124d3d into master Jun 21, 2018
@tripodsan
Copy link
Contributor

I didn't want to break compatibility for compile.
but then we never evolve the API if we already care about backward compatibility. :-)

never mind... we will clean it up eventually. the compile should anyways be async and return a promise....

@tripodsan tripodsan deleted the transient-compiler branch November 7, 2019 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants