LLVM 13 Updates #73
Merged
LLVM 13 Updates #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredwy
reviewed
Aug 2, 2022
| LIST(GET llvm_version_dir 0 llvm_to_use) | ||
| # we detect the install location with brew --prefix llvm | ||
| execute_process( | ||
| COMMAND brew --prefix llvm |
There was a problem hiding this comment.
This is great. Have you tested it with older versions and multiple versions installed?
There was a problem hiding this comment.
With older versions, lets just call 13 the new minimum and dump an error if we are earlier. Out of scope for this PR, so if this works with multiple versions we are good.
There was a problem hiding this comment.
It appears to work as expected.
$ brew install llvm@12
$ mkdir build && cd build
$ cmake .. -GNinja
$ cmake --build .Compiles and points to the right llvm.
|
Looks good to me, just one question. Let me know if you want me to tets that for you. |
|
@jaredwy Thanks for the suggestion to test multiple versions. It works as expected on my machine with multiple versions of LLVM installed. If you're satisfied, please merge at your earliest convenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change builds off of @fosterbrereton's branch
fosterbrereton/llvm13-updates.llvm..gitignoreto ignorebuild*/boost::filesystemchange.Related Issue
Motivation and Context
Required to build with LLVM 13.
How Has This Been Tested?
Tested by running a ninja-powered build on my M1 laptop.
Screenshots (if appropriate):
Types of changes
Checklist: