cleanup

Author: LFDanLu

packages/@react-aria/autocomplete/package.json

@@ -23,7 +23,6 @@
   },
   "dependencies": {
     "@react-aria/combobox": "^3.10.5",
-    "@react-aria/focus": "^3.18.3",
     "@react-aria/i18n": "^3.12.3",
     "@react-aria/listbox": "^3.13.5",
     "@react-aria/searchfield": "^3.7.10",

packages/@react-aria/menu/src/useMenuItem.ts

@@ -123,7 +123,6 @@ export function useMenuItem<T>(props: AriaMenuItemProps, state: TreeState<T>, re
   let isDisabled = props.isDisabled ?? state.selectionManager.isDisabled(key);
   let isSelected = props.isSelected ?? state.selectionManager.isSelected(key);
   let data = menuData.get(state);
-
   let item = state.collection.getItem(key);
   let onClose = props.onClose || data.onClose;
   let router = useRouter();
@@ -163,9 +162,6 @@ export function useMenuItem<T>(props: AriaMenuItemProps, state: TreeState<T>, re
   let keyboardId = useSlotId();
 
   if (data.shouldUseVirtualFocus) {
-    // TODO: finalize if every component that Autocomplete will accept as a filterable child would need to follow this same
-    // logic when creating the id
-    id = `${data.id}-option-${key}`;
     id = getItemId(state, key);
   }
 

packages/@react-stately/autocomplete/src/index.ts

@@ -12,5 +12,4 @@
 
 export {useAutocompleteState} from './useAutocompleteState';
 
-// TODO export the types
 export type {AutocompleteProps, AutocompleteStateOptions, AutocompleteState} from './useAutocompleteState';

packages/@react-stately/autocomplete/src/useAutocompleteState.ts

@@ -19,7 +19,6 @@ export interface AutocompleteState {
   inputValue: string,
   /** Sets the value of the autocomplete input. */
   setInputValue(value: string): void,
-  // TODO: debatable if this state hook needs to exist
   /** The id of the current aria-activedescendant of the autocomplete input. */
   focusedNodeId: string | null,
   /** Sets the id of the current aria-activedescendant of the autocomplete input. */

packages/react-aria-components/stories/Autocomplete.stories.tsx

@@ -42,7 +42,6 @@ export const AutocompleteExample = {
   render: ({onAction, isDisabled, isReadOnly}) => {
     return (
       <Autocomplete isReadOnly={isReadOnly} isDisabled={isDisabled} defaultInputValue="Ba" name="autocomplete-example" data-testid="autocomplete-example">
-        {/* TODO: would the expectation be that a user would render a Group here? Or maybe we could add a wrapper element provided by Autocomplete automatically? */}
         <div>
           <Label style={{display: 'block'}}>Test</Label>
           <Input />