Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back test util docs #5891

Merged
merged 10 commits into from
Apr 22, 2024
Merged

Bring back test util docs #5891

merged 10 commits into from
Apr 22, 2024

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Feb 15, 2024

Turns out I just needed to not delete the dev/util file

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Feb 15, 2024

Please see the following section in the testing docs for more information on how to simulate this action in your
test suite.

// TODO need to also mock the client rect?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be revisited before merging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thought I got rid of all of those, lemme check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked, the section in the main testing docs that is linked should be sufficient along with the link to our tests IMO. Can always add more if need be if people still have trouble. Thanks for catching this one!

@rspbot
Copy link

rspbot commented Apr 5, 2024

snowystinger
snowystinger previously approved these changes Apr 8, 2024
@rspbot
Copy link

rspbot commented Apr 8, 2024

@rspbot
Copy link

rspbot commented Apr 8, 2024

snowystinger
snowystinger previously approved these changes Apr 8, 2024
@rspbot
Copy link

rspbot commented Apr 20, 2024

@rspbot
Copy link

rspbot commented Apr 22, 2024

@rspbot
Copy link

rspbot commented Apr 22, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
DEFAULT_LONG_PRESS_TIME already in set
triggerLongPress already in set
installMouseEvent already in set

@react-aria/test-utils

DEFAULT_LONG_PRESS_TIME

-
+triggerLongPress {
+  element: HTMLElement
+  opts: any
+  returnVal: undefined
+}

triggerLongPress

-
+installMouseEvent {
+  returnVal: undefined
+}

installMouseEvent

-
+installPointerEvent {
+  returnVal: undefined
+}

@react-spectrum/test-utils

DEFAULT_LONG_PRESS_TIME

-
+triggerLongPress {
+  element: HTMLElement
+  opts: any
+  returnVal: undefined
+}

triggerLongPress

-
+installMouseEvent {
+  returnVal: undefined
+}

installMouseEvent

-
+installPointerEvent {
+  returnVal: undefined
+}

installPointerEvent

-
+simulateMobile {
+  width: number
+  returnVal: undefined
+}

pointerMap

-
+simulateDesktop {
+  width: number
+  returnVal: undefined
+}

@LFDanLu LFDanLu merged commit bce308e into main Apr 22, 2024
25 checks passed
@LFDanLu LFDanLu deleted the bring_back_utils branch April 22, 2024 19:52
@dannify dannify removed the release label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants