Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export of clone utility. #117

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Fix export of clone utility. #117

merged 1 commit into from
Nov 4, 2020

Conversation

Aaronius
Copy link
Contributor

@Aaronius Aaronius commented Nov 4, 2020

Description

We're using ES5 to import modules so we have to use ES5 to export the modules (you don't have to, but the process to import the module is a little more involved). In this case, I did an ES6 export default, resulting an error being thrown at runtime. This PR switches it to an ES5 export. I've logged a separate issue to add a lint rule so we can catch this type of thing earlier: https://jira.corp.adobe.com/browse/CORE-54412

Related Issue

It doesn't resolve this issue, but it is related: https://jira.corp.adobe.com/browse/CORE-54412

Motivation and Context

The send event action was throwing an error.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All tests pass and I've made any necessary test changes.
  • I've updated the schema in extension.json or no changes are necessary.

Copy link
Contributor

@ninaceban ninaceban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@Aaronius Aaronius merged commit 944be55 into master Nov 4, 2020
@Aaronius Aaronius deleted the fix-clone branch November 4, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants