Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: internal workspace links #2677

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

castastrophe
Copy link
Collaborator

@castastrophe castastrophe commented Apr 19, 2024

Description

Update all packages to use the workspace protocol and enable the setting for changesets so that it maintains those versions only (no more peerDep updates): https://github.com/changesets/changesets/blob/main/docs/config-file-options.md#bumpversionswithworkspaceprotocolonly-boolean

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe added the skip_vrt Add to a PR to skip running VRT (but still pass the action) label Apr 19, 2024
@castastrophe castastrophe self-assigned this Apr 19, 2024
Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: a33d2de

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 84 packages
Name Type
@spectrum-css/floatingactionbutton Patch
@spectrum-css/opacitycheckerboard Patch
@spectrum-css/illustratedmessage Patch
@spectrum-css/coachindicator Patch
@spectrum-css/contextualhelp Patch
@spectrum-css/progresscircle Patch
@spectrum-css/dropindicator Patch
@spectrum-css/infieldbutton Patch
@spectrum-css/actionbutton Patch
@spectrum-css/pickerbutton Patch
@spectrum-css/alertbanner Patch
@spectrum-css/alertdialog Patch
@spectrum-css/buttongroup Patch
@spectrum-css/clearbutton Patch
@spectrum-css/closebutton Patch
@spectrum-css/colorhandle Patch
@spectrum-css/colorslider Patch
@spectrum-css/inlinealert Patch
@spectrum-css/logicbutton Patch
@spectrum-css/progressbar Patch
@spectrum-css/statuslight Patch
@spectrum-css/swatchgroup Patch
@spectrum-css/actionmenu Patch
@spectrum-css/breadcrumb Patch
@spectrum-css/colorloupe Patch
@spectrum-css/colorwheel Patch
@spectrum-css/datepicker Patch
@spectrum-css/fieldgroup Patch
@spectrum-css/fieldlabel Patch
@spectrum-css/pagination Patch
@spectrum-css/typography Patch
@spectrum-css/accordion Patch
@spectrum-css/actionbar Patch
@spectrum-css/assetcard Patch
@spectrum-css/assetlist Patch
@spectrum-css/coachmark Patch
@spectrum-css/colorarea Patch
@spectrum-css/splitview Patch
@spectrum-css/textfield Patch
@spectrum-css/thumbnail Patch
@spectrum-css/calendar Patch
@spectrum-css/checkbox Patch
@spectrum-css/combobox Patch
@spectrum-css/dropzone Patch
@spectrum-css/helptext Patch
@spectrum-css/steplist Patch
@spectrum-css/taggroup Patch
@spectrum-css/treeview Patch
@spectrum-css/underlay Patch
@spectrum-css/commons Patch
@spectrum-css/divider Patch
@spectrum-css/popover Patch
@spectrum-css/sidenav Patch
@spectrum-css/stepper Patch
@spectrum-css/tooltip Patch
@spectrum-css/avatar Patch
@spectrum-css/button Patch
@spectrum-css/dialog Patch
@spectrum-css/miller Patch
@spectrum-css/picker Patch
@spectrum-css/rating Patch
@spectrum-css/search Patch
@spectrum-css/slider Patch
@spectrum-css/swatch Patch
@spectrum-css/switch Patch
@spectrum-css/asset Patch
@spectrum-css/badge Patch
@spectrum-css/modal Patch
@spectrum-css/radio Patch
@spectrum-css/table Patch
@spectrum-css/toast Patch
@spectrum-css/card Patch
@spectrum-css/dial Patch
@spectrum-css/icon Patch
@spectrum-css/link Patch
@spectrum-css/menu Patch
@spectrum-css/page Patch
@spectrum-css/site Patch
@spectrum-css/tabs Patch
@spectrum-css/tray Patch
@spectrum-css/well Patch
@spectrum-css/tag Patch
@spectrum-css/preview Patch
@spectrum-tools/documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 19, 2024

File metrics

Summary

Total size: 4.64 MB*

🎉 No changes detected in any packages

* Size determined by adding together the size of the main file for all packages in the library.
* Results are not gzipped or minified.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Apr 19, 2024

🚀 Deployed on https://pr-2677--spectrum-css.netlify.app

@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch 2 times, most recently from b6e3cb9 to 0d8f403 Compare April 24, 2024 14:22
@castastrophe
Copy link
Collaborator Author

Note to self: I need to validate that workspace is replaced during a changeset release

@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch 2 times, most recently from a3d768e to 97e5393 Compare April 26, 2024 22:04
@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch from 97e5393 to d3524bf Compare May 7, 2024 19:31
@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch 4 times, most recently from d0c7fa2 to b68b1dc Compare May 22, 2024 15:22
@castastrophe castastrophe requested a review from pfulton May 22, 2024 15:29
@castastrophe castastrophe marked this pull request as ready for review May 22, 2024 15:30
@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch from b68b1dc to 384c532 Compare May 22, 2024 15:30
@castastrophe castastrophe added run_vrt For use on PRs looking to kick off VRT ready-for-review and removed skip_vrt Add to a PR to skip running VRT (but still pass the action) labels May 22, 2024
@castastrophe castastrophe force-pushed the chore-internal-workspace-links branch from 384c532 to a33d2de Compare May 22, 2024 15:32
@castastrophe castastrophe merged commit d83200c into main May 22, 2024
13 checks passed
@castastrophe castastrophe deleted the chore-internal-workspace-links branch May 22, 2024 16:53
@github-actions github-actions bot mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review run_vrt For use on PRs looking to kick off VRT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants