Skip to content

Commit 3998d91

Browse files
fix(combobox): design feedback updates
- corrects the s2 foundations disabled border color - corrects the s2 foundations focus+hover border color
1 parent a3577ee commit 3998d91

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

packages/combobox/src/combobox.css

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,25 @@ sp-popover:not(sp-overlay sp-popover) {
4848
margin: 0;
4949
}
5050

51+
/* TODO: The following two selector blocks are meant to override the #textfield:hover styles.
52+
* #textfield:hover .input was overriding the disabled border colors in S2 foundations, as well
53+
* as the border colors when a combobox was focused+hovered.
54+
*/
55+
:host([disabled]) #textfield .input,
56+
:host([disabled]) #textfield:hover .input {
57+
border-color: var(
58+
--mod-combobox-border-color-disabled,
59+
var(--spectrum-combobox-border-color-disabled)
60+
);
61+
}
62+
63+
#textfield:hover .input:focus {
64+
border-color: var(
65+
--mod-combobox-border-color-default,
66+
var(--spectrum-combobox-border-color-focus-hover)
67+
);
68+
}
69+
5170
::slotted([slot='option']) {
5271
display: none;
5372
}

0 commit comments

Comments
 (0)