Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support of tight bounding boxes for images or handling some glyphs wh… #173

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

tjindal
Copy link
Member

@tjindal tjindal commented May 25, 2022

…ich crops in output

To provide output in a tight bound box by computing the bounds of image and then draw a canvas of bounds size.
This change is necessary for that svg files having viewbox values are small (width & height) as compare to image bounds (width & height)

initially by using default canvas, we compute bounds of image. Then by using same bounds draw the required canvas again and draw the image on new canvas. it will ensure our image will fits correctly into new canvas.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.

  • My code follows the code style of this project.

  • My change requires a change to the documentation.

  • I have updated the documentation accordingly.

  • I have read the CONTRIBUTING document.

  • I have added tests to cover my changes.

  • All new and existing tests passed.
    xx

@tjindal tjindal requested a review from dirkschulze as a code owner May 25, 2022 13:12
@tjindal tjindal requested a review from Saikat1911 May 25, 2022 13:15
@tjindal tjindal merged commit 2f7fd8d into main Jun 9, 2022
tjindal added a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants