Revert "Allow clean build process (#221)" #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5cf92d3. Unfortunately, this complicates the crate publishing process and needs more work than I have time for today.
|
See test failure logs from #226 for details. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 9 9
Lines 1857 1857
=======================================
Hits 1822 1822
Misses 35 35 ☔ View full report in Codecov by Sentry. |
|
Closing. I managed to find a fix for #226. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, I have to back out #221 because it breaks the crate publish workflow and I don't have time today to find a fix for that.
@uttarayan21 if you can find a way to reinstate the changes from #221 that passes the
cargo publishpreflight check, I'd welcome that PR. If not, I will circle back to this problem when I have time, but that is likely to be a few weeks.