Skip to content

Conversation

caiquecastro
Copy link
Contributor

@caiquecastro caiquecastro commented Jan 31, 2019

Proposed changes

It assumes the port is 2525, but if I have a local server for development and a production SMTP server with different ports, it's needed to be configurable

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

N/A

It assumes the port is 2525, but if I have a local server for development and a production SMTP server with different ports, it's needed to be configurable
@coveralls
Copy link

Coverage Status

Coverage decreased (-8.9%) to 84.211% when pulling 32cf6e2 on caiquecastro:patch-1 into 4aef9bb on adonisjs:develop.

@RomainLanz RomainLanz merged commit c0f565a into adonisjs:develop Jan 31, 2019
@caiquecastro caiquecastro deleted the patch-1 branch February 6, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants