Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add discord driver #120

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Conversation

Mesteery
Copy link
Contributor

Proposed changes

Add the Discord OAuth2 driver.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@Mesteery Mesteery force-pushed the feat/discord-driver branch 2 times, most recently from b10e43c to 85f4c1f Compare May 28, 2021 21:49
@thetutlage
Copy link
Member

Appreciate you taking out time to add proper types as well. Going to give it a test run in a while :)

adonis-typings/ally.ts Outdated Show resolved Hide resolved
adonis-typings/ally.ts Outdated Show resolved Hide resolved
examples/config/ally.ts Outdated Show resolved Hide resolved
src/Drivers/Discord/index.ts Outdated Show resolved Hide resolved
adonis-typings/ally.ts Outdated Show resolved Hide resolved
adonis-typings/ally.ts Outdated Show resolved Hide resolved
adonis-typings/ally.ts Show resolved Hide resolved
@thetutlage
Copy link
Member

Hey, the tests are failing coz there are styling issues. https://github.com/adonisjs/ally/pull/120/checks?check_run_id=2704363449

Just run npm run format and then push the code

@Mesteery
Copy link
Contributor Author

Mesteery commented Jun 1, 2021

Yes, I saw that the CI failed. However, in local the tests pass.

@thetutlage
Copy link
Member

Did you try to run npm run format and see anything change?

@Mesteery
Copy link
Contributor Author

Mesteery commented Jun 2, 2021

Yes, there are no change. Also, my branch is up to date with the remote.
I'll retry anyway.

@Mesteery
Copy link
Contributor Author

Mesteery commented Jun 2, 2021

It worked (on my another machine), I don't understand why it didn't work before. Sorry.

@thetutlage thetutlage merged commit 2eaab9a into adonisjs:develop Jun 2, 2021
@thetutlage
Copy link
Member

Looks good. Thanks for the PR :)

@Mesteery Mesteery deleted the feat/discord-driver branch June 2, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants