feat: yarn berry support #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test covering the behavior for yarn@berry would be great to have See here for reference : |
Julien-R44
reviewed
May 19, 2024
|
Looks fine to me! Thanks a lot @RomainLanz Since you are way more familiar with yarn than me, could you give it a quick review? |
|
Thanks! |
Julien-R44
pushed a commit
that referenced
this pull request
May 22, 2024
* feat: yarn berry support * fix: add missing yarn berry file to move during build * chore: add tests
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
adonisjs/core#4568
❓ Type of change
📚 Description
This PR adds support for yarn berry into assembler (required to then add it to core).
It replaces
lockFileinSUPPORT_PACKAGE_MANAGERSbecause yarn berry also need some other metadata files, but it might be useful for other package managers too.📝 Checklist
Not sure there is documentation to be updated, it should just make it work out of the box for yarn berry.