Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema): add alias to createTableIfNotExists #190

Merged
merged 2 commits into from
Oct 18, 2017
Merged

fix(schema): add alias to createTableIfNotExists #190

merged 2 commits into from
Oct 18, 2017

Conversation

RomainLanz
Copy link
Member

Closes #189

SkyzohKey
SkyzohKey approved these changes Oct 12, 2017
View reviewed changes
Copy link

@SkyzohKey SkyzohKey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

webdevian
webdevian reviewed Oct 12, 2017
View reviewed changes
src/Schema/index.js Outdated
@@ -287,6 +287,15 @@ class Schema {
}

/**
* Alias for @ref('Schema.createTableIfNotExists')
*
* @method dropIfExists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect docblock?

@RomainLanz
Copy link
Member Author

Thanks, fixed! 😄

@thetutlage thetutlage merged commit 1ce3d72 into adonisjs:develop Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webdevian webdevian webdevian left review comments

@SkyzohKey SkyzohKey SkyzohKey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomainLanz @webdevian @SkyzohKey @thetutlage