Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lucid): allow to unfreeze model instance #266

Merged
merged 1 commit into from
Dec 21, 2017
Merged

feat(lucid): allow to unfreeze model instance #266

merged 1 commit into from
Dec 21, 2017

Conversation

radmen
Copy link
Contributor

@radmen radmen commented Dec 21, 2017

I was working on SoftDelete trait for models. I've found that there's a bug in proxyHandler which prevented from unfreezing model.

This PR introduces unfreeze() method which allows to set $frozen to false.

@coveralls
Copy link

coveralls commented Dec 21, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 96.413% when pulling 906c3c0 on radmen:fix-allow-to-change-frozen-attribute into 874268a on adonisjs:develop.

@thetutlage thetutlage merged commit 1cacc58 into adonisjs:develop Dec 21, 2017
@thetutlage
Copy link
Member

Thanks 👍

@radmen radmen deleted the fix-allow-to-change-frozen-attribute branch December 21, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radmen @coveralls @thetutlage