Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some cellType and columnType docs #91

Merged
merged 5 commits into from
Jul 1, 2016
Merged

Add some cellType and columnType docs #91

merged 5 commits into from
Jul 1, 2016

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Jul 1, 2016

I did some destructuring as well, for consistency of not using Ember., but destructuring instead.

@taras
Copy link
Collaborator

taras commented Jul 1, 2016

💯 thank you!

@RobbieTheWagner
Copy link
Member Author

No problem @taras! Trying to help out where I can 😄

@offirgolan offirgolan mentioned this pull request Jul 1, 2016
4 tasks
@offirgolan
Copy link
Collaborator

offirgolan commented Jul 1, 2016

@rwwagner90 thanks for taking the time to document the cell and column types, I think it looks great 😺! In terms of styling, Im not really a fan of declaring Component as a constant (especially if there is no other constants in the rest of the file).

@RobbieTheWagner
Copy link
Member Author

@offirgolan I just try to destructure whatever I can. Is there a reason you particularly do not like doing so with Component?

@offirgolan
Copy link
Collaborator

Honestly, its nothing more than of a personal preference / pet-peeve

@RobbieTheWagner
Copy link
Member Author

@offirgolan I'm just not sure what makes component special. I thought the standards were you should destructure everything out of the Ember namespace that you can rather than using Ember.Component Ember.Route etc. I'll be glad to change it back if you'd like though.

@offirgolan
Copy link
Collaborator

Thanks @rwwagner90

@offirgolan offirgolan merged commit af7e8de into adopted-ember-addons:master Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants