Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong openjdk checkout directory #2130

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

junyuanz1
Copy link
Contributor

@junyuanz1 junyuanz1 commented Dec 18, 2020

we will run into the following error when JDK_REPO, JDK_BRANCH, and OPENJDK_SHA are all set:

getOpenjdk:
     [echo]  Using user specified repo and branch
     [echo] git clone -q -b test#7642 https://ms-juniper@dev.azure.com/ms-juniper/Juniper/_git/jdk11u openjdktemp

BUILD FAILED
D:\a\1\openjdk-tests\TKG\scripts\build_test.xml:60: The following error occurred while executing this line:
D:\a\1\openjdk-tests\openjdk\build.xml:269: The following error occurred while executing this line:
D:\a\1\openjdk-tests\openjdk\build.xml:121: The directory D:\a\1\openjdk-tests\openjdk\openjdk-jdk does not exist

the checkout directory for the following line should be the git clone directory which is the openjdktemp

@karianna karianna added the bug label Dec 18, 2020
@karianna karianna added this to the December 2020 milestone Dec 18, 2020
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @junyuan-z 👍

@smlambert smlambert merged commit 9208f55 into adoptium:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants