Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result comment for docker tests #4527

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

LongyuZhang
Copy link
Contributor

  • Add result comment for docker tests to correct TKG summary
  • Related Issue: ibm_git/runtimes/backlog/issues/1056

- Add result comment for docker tests to correct TKG summary

Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
@LongyuZhang
Copy link
Contributor Author

Test Link: hyc_grinder 32426

@@ -578,6 +582,7 @@ generate_dockerfile() {
print_legal ${file};
print_adopt_test ${file} ${test};
print_image_args ${file} ${os} ${version} ${vm} ${package} ${build};
print_result_comment_arg ${file};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print_result_comment_arg() does not take any parameter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my mistake :)

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renfeiw renfeiw merged commit ded5ce4 into adoptium:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants