Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add result comment for docker tests #4527

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Add result comment for docker tests #4527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions external/dockerfile_functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ print_test_tag_arg() {
echo -e "ARG ${test}=${tag}\n" >> ${file}
}

print_result_comment_arg() {
local file=$1
echo -e "ENV RESULT_COMMENT=\"IN DOCKER\"\n" >> ${file}
}

# Select the ubuntu OS packages
print_ubuntu_pkg() {
Expand Down Expand Up @@ -578,6 +582,7 @@ generate_dockerfile() {
print_legal ${file};
print_adopt_test ${file} ${test};
print_image_args ${file} ${os} ${version} ${vm} ${package} ${build};
print_result_comment_arg ${file};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print_result_comment_arg() does not take any parameter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, my mistake :)

print_test_tag_arg ${file} ${test} ${tag_version};
print_${os}_pkg ${file} "${!packages}";

Expand Down