Simplify mpdm channel names #96
Comments
|
Yes, definitely opportunities to DRY up the code. Shortening mpdm channel names sounds good to me too. Thanks @fancypantalons. |
|
Apologies for the spam, this is what I get for not updating and running the UTs before pushing to my repo... Anyway, a4d8a79 is in good shape, now, I think. I've added an additional test to test_mpim.js and everything passes now after I hunted down a couple regressions. |
|
Excellent. I'll go through these next time I'm at a computer. |
adsr
pushed a commit
that referenced
this issue
Jun 27, 2020
This commit implements the proposal laid out in issue #96. By default, multi-party direct message chats are directly mapped to an IRC channel name that matches this scheme: #mpdm-mynick--nick1--nick2--nick3 This is pretty unwieldly. To try and make these channel names a bit more manageable, this changeset adds a new preference: short-group-chat-names If this is supplied with the login token, these chat names are instead mapped to this scheme: &nick1-nick2-nick3 This uses the server local chat prefix to differentiate between normal and group chats, removes the current user nick, and then takes out some extra hyphens to compress the whole thing down. This is made optional through a preference so as not to disrupt the current UX.
|
Merged in 86d6e94. Thanks! |
pbui
pushed a commit
to pbui/irslackd
that referenced
this issue
Feb 25, 2021
This commit implements the proposal laid out in issue adsr#96. By default, multi-party direct message chats are directly mapped to an IRC channel name that matches this scheme: #mpdm-mynick--nick1--nick2--nick3 This is pretty unwieldly. To try and make these channel names a bit more manageable, this changeset adds a new preference: short-group-chat-names If this is supplied with the login token, these chat names are instead mapped to this scheme: &nick1-nick2-nick3 This uses the server local chat prefix to differentiate between normal and group chats, removes the current user nick, and then takes out some extra hyphens to compress the whole thing down. This is made optional through a preference so as not to disrupt the current UX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've got a prototype implementation if this sounds interesting.
From a UX perspective, mpdm channel names are... definitely a nuisance, following a pattern like:
I'm experimenting with an alternative mapping that uses the server local chantype '&', eliminates the user's own nickname, and then pulls out the extra hyphens as follows:
(Yeah, this isn't really what the '&' chantype is for, but in this context I think it's fine to use it). The benefit here is brevity. The channels are still distinguishable from non-mpdm channels (now by chantype prefix), but they're not nearly as unwieldy.
Obviously this would be a jarring change for existing users so I'd propose a refactoring to centralize the logic for:
Then, make the behaviour switchable with an opt-in command-line flag or other setting if that's desirable.
Thoughts?
The text was updated successfully, but these errors were encountered: