Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs#49 urllib fix #52

Merged
merged 5 commits into from
Apr 21, 2016
Merged

Refs#49 urllib fix #52

merged 5 commits into from
Apr 21, 2016

Conversation

adubkov
Copy link
Owner

@adubkov adubkov commented Apr 21, 2016

This PR contains:

TODO: Make better tests for get_id.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 90.909% when pulling 881ca12 on refs#49-urllib-fix into 20d26ef on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 90.909% when pulling a88e699 on refs#49-urllib-fix into 20d26ef on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 90.909% when pulling a88e699 on refs#49-urllib-fix into 20d26ef on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 90.909% when pulling a88e699 on refs#49-urllib-fix into 20d26ef on master.

@maksim77
Copy link
Collaborator

I think that looks great!
👍🏻

@adubkov adubkov merged commit afa208f into master Apr 21, 2016
@adubkov adubkov deleted the refs#49-urllib-fix branch April 21, 2016 10:06
This was referenced Apr 22, 2016
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maksim77 maksim77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adubkov @coveralls @maksim77