Fix #374 and #409 - Prevent XSS and add Markdown support #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the XSS vulnerability by handling three different formatting modes we support separately.
A new helper
parse-message.js
was added toutils
that uses the popular battle-tested unified library with plugins for HTML and Markdown to sanitize and translate Markdown to HTML, adding full Markdown support.The default formatting mode no longer uses
v-html
to dynamically add arbitrary HTML to the DOM, however, users can still customize messages with dynamic HTML, opting in usingtext-formatting='{ "html": true }'
. The injected HTML is first sanitized to remove dangerous elements.text-formatting='{ "markdown": true }'
was similarly added to allow users to use CommonMark-compliant Markdown.The default formatting functions in
FormatMessage.vue
were refactored intoparse-message.js
to consolidate the parsing logic.Note these changes also set the groundwork to address #409.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)