Skip to content

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 5, 2025

This PR upgrades the CodeQL CLI version to v2.23.0.

Changes made:

  • Updated CodeQLCLI to 2.23.0
  • Updated CodeQLStandardLibrary to codeql-cli/v2.23.0
  • Updated CodeQLCLIBundle to codeql-bundle-v2.23.0
  • Upgraded all CodeQL pack lock files using codeql pack upgrade

@github-actions github-actions bot force-pushed the codeql/upgrade-to-v2.23.0 branch from 90b4707 to 9285ed3 Compare September 9, 2025 00:49
jeongsoolee09
jeongsoolee09 previously approved these changes Sep 15, 2025
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongsoolee09 jeongsoolee09 dismissed their stale review September 15, 2025 14:41

Manual trigger of check failed.

The latest changes in CodeQL for JavaScript apparently improve on
the reported alert location.
@jeongsoolee09
Copy link
Contributor

There apparently was an improvement in CodeQL (could be only for JavaScript though) on the ending location of data flow nodes. For example, the x as in const x = y at line 1 was previously file://somefile.js:1:6:1:11 (which is wrong) but is now computed correctly as file://somefile.js:1:6:1:8.

Inspected and updated all changes.

@github-actions github-actions bot force-pushed the codeql/upgrade-to-v2.23.0 branch from 56909a9 to 5c25e78 Compare September 17, 2025 00:49
…ity/codeql-sap-js into codeql/upgrade-to-v2.23.0
Copy link
Contributor

@knewbury01 knewbury01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm also! It is clear that the expected file changes are as @jeongsoolee09 documented and these are expected!

@jeongsoolee09 jeongsoolee09 merged commit 03a3884 into main Sep 17, 2025
10 of 13 checks passed
@jeongsoolee09 jeongsoolee09 deleted the codeql/upgrade-to-v2.23.0 branch September 17, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants