Skip to content

Conversation

LeShadow
Copy link
Contributor

@LeShadow LeShadow commented Jul 3, 2024

This PR fixes the bug that was in #5 .

The altered output from v1.1.0 gives an error when you use the output from the action in this type of context:

strategy:
      fail-fast: false
      matrix:
        language: ${{ fromJSON(needs.create-matrix.outputs.matrix) }}

It cannot parse the JSON properly and thus the parsing ends in an empty value as well. This fix, which was mentioned in #5 should fix that.

Credit to the proposed fix by @gurucloudsec

@LeShadow LeShadow requested a review from leftrightleft as a code owner July 3, 2024 18:31
@LeShadow LeShadow changed the title Fix output bug for workflows Bugfix for #5: Altered output breaks functionality with strategy Jul 3, 2024
@leftrightleft
Copy link
Contributor

@CallMeGreg Can you take a look at this PR? This change reverts the updates you made in this PR

@CallMeGreg
Copy link
Contributor

@leftrightleft LGTM 👍

Copy link
Contributor

@leftrightleft leftrightleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix @LeShadow @gurucloudsec

@leftrightleft leftrightleft merged commit 00ba870 into advanced-security:main Jul 8, 2024
@LeShadow LeShadow deleted the fix_output branch July 12, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants