Use $VISUAL and $EDITOR env vars for editor selection #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the Edit function in the editor package to use the standard UNIX convention of $VISUAL and $EDITOR environment variables for selecting the text editor. If $VISUAL is set, it takes precedence. If $VISUAL is not set but EDITOR is set, $EDITOR is used. If neither is set, it falls back to using the default editor, which is set to "nano". This allows users to customize their preferred text editor by setting the $VISUAL or $EDITOR environment variable, following the common convention in UNIX-based systems.
adzimzf
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request modifies the
Editfunction in theeditorpackage to use the standard *nix convention ofVISUALandEDITORenvironment variables for selecting the text editor.Motivation and Context
Currently, the
Editfunction always uses theDefaultEditor, which is hardcoded as "nano". This limits the flexibility for users who prefer to use a different text editor.Changes
VISUALenvironment variable is set usingos.Getenv("VISUAL"). If it is set, use its value as the editor.VISUALis not set, check if theEDITORenvironment variable is set usingos.Getenv("EDITOR"). If it is set, use its value as the editor.VISUALnorEDITORis set, fall back to using theDefaultEditor, which is set to "nano".Verified
VISUALenvironment variable to a different editor (e.g., "vim") and verified that the specified editor was used when calling theEditfunction.VISUALnorEDITORis set and confirmed that it falls back to using "nano" as the default editor.Checklist
Please review and provide any feedback or suggestions for improvement.