-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema generation and remove default values #110
Conversation
kvaps
commented
Apr 26, 2024
- Remove any possible default users and settings and move them to examples
- Use readme-generator-for-helm for generate openapi schema
5522e23
to
be9b3ad
Compare
@@ -0,0 +1,36 @@ | |||
--- | |||
apiVersion: kamaji.clastix.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure here, can you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is from another pull request #95 and will be updated to this version once the first one is merged
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
be9b3ad
to
f25bbd5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are already in the release 0.4.1, now you are rolling them into another branch. Ok
Yeah we forgot to merge them into v0.4.0, would go to v0.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good