Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema generation and remove default values #110

Merged
merged 6 commits into from
May 9, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Apr 26, 2024

  • Remove any possible default users and settings and move them to examples
  • Use readme-generator-for-helm for generate openapi schema

@kvaps kvaps force-pushed the openapi-schema-generation branch 2 times, most recently from 5522e23 to be9b3ad Compare April 26, 2024 13:22
@themoriarti themoriarti self-requested a review April 26, 2024 13:29
@@ -0,0 +1,36 @@
---
apiVersion: kamaji.clastix.io/v1alpha1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure here, can you clarify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is from another pull request #95 and will be updated to this version once the first one is merged

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps force-pushed the openapi-schema-generation branch from be9b3ad to f25bbd5 Compare April 26, 2024 14:34
Copy link
Collaborator

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps kvaps marked this pull request as ready for review May 8, 2024 08:31
Copy link
Collaborator

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are already in the release 0.4.1, now you are rolling them into another branch. Ok

@kvaps
Copy link
Member Author

kvaps commented May 8, 2024

Yeah we forgot to merge them into v0.4.0, would go to v0.5.0

@kvaps kvaps marked this pull request as draft May 8, 2024 18:55
Copy link
Collaborator

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants