Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GOV] Revert CoC to remove FK changes #17

Merged
merged 9 commits into from
Feb 5, 2023
Merged

[GOV] Revert CoC to remove FK changes #17

merged 9 commits into from
Feb 5, 2023

Conversation

aiwalter
Copy link
Contributor

@aiwalter aiwalter commented Feb 5, 2023

Reverts sktime PR #3674

@aiwalter aiwalter added the governance Governance and community management label Feb 5, 2023
@aiwalter aiwalter changed the title Revert CoC to remove FK changes [GOV] Revert CoC to remove FK changes Feb 5, 2023
patrickzib
patrickzib previously approved these changes Feb 5, 2023
View reviewed changes
patrickzib
patrickzib approved these changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Missed the FK part. Good addition.

patrickzib
patrickzib requested changes Feb 5, 2023
View reviewed changes
docs/source/get_involved/code_of_conduct.rst Show resolved Hide resolved
docs/source/get_involved/code_of_conduct.rst Outdated Show resolved Hide resolved
docs/source/get_involved/code_of_conduct.rst Outdated Show resolved Hide resolved
@aiwalter aiwalter mentioned this pull request Feb 5, 2023
Merged
patrickzib
patrickzib approved these changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@patrickzib patrickzib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now. Thanks

GuzalBulatova
GuzalBulatova approved these changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@GuzalBulatova GuzalBulatova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aiwalter , this looks good! Would like to come back to this in the future with the whole team. I'd like to rewrite this to be even more concise and resemble CoC of pandas / numpy (< 200 lines - ish).

@aiwalter aiwalter merged commit 725cc1c into main Feb 5, 2023
@aiwalter aiwalter deleted the mw/coc_revert branch February 5, 2023 13:36
@MatthewMiddlehurst MatthewMiddlehurst mentioned this pull request Feb 7, 2023
Closed
aiwalter added a commit that referenced this pull request Feb 15, 2023
@aiwalter @MatthewMiddlehurst
@patrickzib @lmmentel
update from main (#65)
9c9b98a 
* [GOV] Revert CoC to remove FK changes (#17)

* Revert CoC to remove FK changes

* Removed FK name from COC

* Removed FK name from COC

* Removed NumFOCUS as second CoCC

* Remove NumFOCUS

* Removed NumFOCUS

* Removed NumFOCUS

* [GOV] Removed 7 days discussion period before votings. Removed weekend rule by adding 2 days instead (#41)

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 21 days and chanfed back to 14 days

* [GOV] CC and CoC term limitation to 2 years (#22)

* [FORK] Update README (IN PROGRESS) (#43)

* simple readme name replace

* manual changes

* disclaimer

* readme split

* [GOV] Updated team page (#19)

* Updated team page

* previous devs

* missed one

---------

Co-authored-by: Matthew Middlehurst <m.middlehurst@uea.ac.uk>

* [FORK] Revert #15 "Remove workflow files" (MERGE WHEN REPO PUBLIC) (#16)

* temporarily stop this action

* comment out all github workflows

* revert

* remove workflows

* add workflows

* uncommented

* license update (#56)

* [BUG] Update check_n_jobs (#14)

* check_n_jobs

* check_n_jobs

* min 1 thread

* Added CoCC members (#57)

* [ENH] Dictionary Classifiers (#58)

Maintenance of Dictionary Classifiers
- Reverts alphabet_size=4 for BOSS and WEASEL,
- carries out deprecation of cBOSS
- adds dilation to SFAFast
- Tidies up Doc-Strings

* remove shellcheck (#60)

* add disclaimer (#64)

---------

Co-authored-by: Matthew Middlehurst <pfm15hbu@uea.ac.uk>
Co-authored-by: Matthew Middlehurst <m.middlehurst@uea.ac.uk>
Co-authored-by: Patrick Schäfer <patrick.schaefer@hu-berlin.de>
Co-authored-by: Lukasz Mentel <lmmentel@users.noreply.github.com>
MatthewMiddlehurst added a commit that referenced this pull request Jul 9, 2024
@MatthewMiddlehurst @TonyBagnall @hadifawaz1999
[MNT] Fix certain workflow actions for forks and add button for reset…
027d651 
…ting CI (#1764)

* [MNT] Bot to make empty commits (#15)

* CI fun

* comments and token

* [MNT] empty commit PR 2 (#16)

* CI fun

* comments and token

* comments

* skip dirty check

* Empty commit for CI

* empty comment 3 (#17)

* comment

* prs only

* comment

* Empty commit for CI

* empty commit 4 (#18)

* comment

* correct branch

* Empty commit for CI

* empty commit 5 (#19)

* comment

* branch

* empty commit 6 (#20)

* [BUG] fix padder fit_values (#1752)

* fix padder

* declare var

* [DOC,MNT] Documentation updates and deprecation warning for `v1.0.0` (#1743)

* forecasting docs

* v1.0.0 mass deprecation message

* index fix

* installation

* typos

* comment

* pushing to forks is crazy

* dont create branches

* [MNT] Unit testing revamp part 1: `check_estimator` (#1479)

* remove no soft deps job and expand full no soft deps job

* no PR testing flag

* module soft deps

* is this actually returning an empty list

* import modules now

* clear out module soft dep

* check_estimator

* check_estimator updates

* import

* more complete functions and tests

* fix

* coverage and paramterize function test

* testing data start

* testing data start

* testing data cont

* real partial

* cont

* testing data changes

* examples revert

* fourier features

* Revert "fourier features"

This reverts commit 567c5e1.

* legacy skip

* init

* move to legacy

* example data update

* testing data

* imports

* examples

* testing update

* multiindex

* multiindex fixes

* multiindex returns

* test

* test

* docs, tests and fixes

* comments

* last bits

* refactor testing folder

* imports

* series generators

* fixes

* make_series legacy

* merge

* forecasting functions

* fixes

* fixes

* fixes

* testing

* examples

* convert checks

* fixes

* docs

* ad datasets

* more docs

* forecasting compose

* forecasting

* delete forecasting api docs

* docs

* revert and comment init

* imports

* import test

* uncomment

* docstrings

* no imports

* package name

* import

* docstring

* fixes

* remove legacy and doc fix

* [ENH] Channel selection rocket wrapper (#1504)

* base channel selector

* base channel selector

* random channel selector

* elbow class test

* random channel selector

* base channel selector

* base channel selector

* revert registry

* draft channel selector

* class method

* test channel scorer

* docstring

* remove unnecessary ExponentTransform import

* deprecate DateTime

* Revert "deprecate DateTime"

This reverts commit 98b29e6.

* channel selection

* remove dependency

* move tests to fit

* move tests to fit

* channel scorer test

* add to API

* maint

* maint

---------

Co-authored-by: Tony Bagnall <ajb@uea.ac.uk>

* empty commit 7 (#21)

* comment

* remove branch param

* fixes

* Empty commit for CI

* empty commit 8 (#22)

* comment

* repo and branch

* comment

* empty commit 9 (#23)

* [BUG] fix padder fit_values (#1752)

* fix padder

* declare var

* [DOC,MNT] Documentation updates and deprecation warning for `v1.0.0` (#1743)

* forecasting docs

* v1.0.0 mass deprecation message

* index fix

* installation

* typos

* [MNT] Unit testing revamp part 1: `check_estimator` (#1479)

* remove no soft deps job and expand full no soft deps job

* no PR testing flag

* module soft deps

* is this actually returning an empty list

* import modules now

* clear out module soft dep

* check_estimator

* check_estimator updates

* import

* more complete functions and tests

* fix

* coverage and paramterize function test

* testing data start

* testing data start

* testing data cont

* real partial

* cont

* testing data changes

* examples revert

* fourier features

* Revert "fourier features"

This reverts commit 567c5e1.

* legacy skip

* init

* move to legacy

* example data update

* testing data

* imports

* examples

* testing update

* multiindex

* multiindex fixes

* multiindex returns

* test

* test

* docs, tests and fixes

* comments

* last bits

* refactor testing folder

* imports

* series generators

* fixes

* make_series legacy

* merge

* forecasting functions

* fixes

* fixes

* fixes

* testing

* examples

* convert checks

* fixes

* docs

* ad datasets

* more docs

* forecasting compose

* forecasting

* delete forecasting api docs

* docs

* revert and comment init

* imports

* import test

* uncomment

* docstrings

* no imports

* package name

* import

* docstring

* fixes

* remove legacy and doc fix

* [ENH] Channel selection rocket wrapper (#1504)

* base channel selector

* base channel selector

* random channel selector

* elbow class test

* random channel selector

* base channel selector

* base channel selector

* revert registry

* draft channel selector

* class method

* test channel scorer

* docstring

* remove unnecessary ExponentTransform import

* deprecate DateTime

* Revert "deprecate DateTime"

This reverts commit 98b29e6.

* channel selection

* remove dependency

* move tests to fit

* move tests to fit

* channel scorer test

* add to API

* [DEP] Exclusion list  (#1730)

* remove dependency

* excluded list

* [MNT] Removing `tensorflow_addons` dependency (#1421)

* tensorflow bound

* add manually instance normalization

* empty commit

* fix doxs

* fix bug

* add maintainer

* re arrange

* dep on utils

* fix comments

* add version and file to header

* re add conflict

* remove addon

* only adodn remove

* add typeguard dep

* remove addons from test

* remove tag of python<3.12 from base class

* edit pyptoject for test details

* remove typeguard

* remove addons

* remove typeguard

* fix bug in python version

* remove config on python < 3.12

* remove python version from test

* remove python version from base

* use group norm

* re-add 3.12 limit

* remove tags and add python version

* skip random state clr test

* fix test all networks

* set y for channel selection test

* set y for channel selection test

---------

Co-authored-by: hadifawaz1999 <hadifawaz2291999@gmail.com>
Co-authored-by: Tony Bagnall <ajb@uea.ac.uk>

* comment

* Empty commit for CI

* uncomment

---------

Co-authored-by: Tony Bagnall <ajb@uea.ac.uk>
Co-authored-by: hadifawaz1999 <hadifawaz2291999@gmail.com>
Co-authored-by: MatthewMiddlehurst <MatthewMiddlehurst@users.noreply.github.com>

---------

Co-authored-by: MatthewMiddlehurst <MatthewMiddlehurst@users.noreply.github.com>
Co-authored-by: Tony Bagnall <ajb@uea.ac.uk>
Co-authored-by: hadifawaz1999 <hadifawaz2291999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuzalBulatova GuzalBulatova GuzalBulatova approved these changes

@patrickzib patrickzib patrickzib approved these changes

Assignees
No one assigned
Labels
governance Governance and community management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aiwalter @patrickzib @GuzalBulatova