Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Dictionary Classifiers #58

Merged
merged 4 commits into from
Feb 14, 2023
Merged

[ENH] Dictionary Classifiers #58

merged 4 commits into from
Feb 14, 2023

Conversation

patrickzib
Copy link
Contributor

Maintenance of Dictionary Classifiers

  • Reverts alphabet_size=4 for BOSS and WEASEL,
  • carries out deprecation of CBOSS
  • adds dilation to SFAFast
  • Tidies up Doc-Strings

@patrickzib patrickzib changed the title Dictionary Classifiers [ENH] Dictionary Classifiers Feb 14, 2023
@patrickzib patrickzib added enhancement New feature, improvement request or other non-bug code enhancement classification Classification package labels Feb 14, 2023
@patrickzib patrickzib linked an issue Feb 14, 2023 that may be closed by this pull request
TonyBagnall
TonyBagnall previously approved these changes Feb 14, 2023
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, except for a block of commented out code you might want to remove

sktime/transformations/panel/dictionary_based/_sfa_fast.py Outdated Show resolved Hide resolved
@patrickzib patrickzib merged commit 5860e5b into main Feb 14, 2023
@patrickzib patrickzib deleted the WEASEL branch February 14, 2023 15:31
aiwalter added a commit that referenced this pull request Feb 15, 2023
* [GOV] Revert CoC to remove FK changes (#17)

* Revert CoC to remove FK changes

* Removed FK name from COC

* Removed FK name from COC

* Removed NumFOCUS as second CoCC

* Remove NumFOCUS

* Removed NumFOCUS

* Removed NumFOCUS

* [GOV] Removed 7 days discussion period before votings. Removed weekend rule by adding 2 days instead (#41)

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 7 days discussion time for CC and CoC votes

* Removed 21 days and chanfed back to 14 days

* [GOV] CC and CoC term limitation to 2 years (#22)

* [FORK] Update README (IN PROGRESS) (#43)

* simple readme name replace

* manual changes

* disclaimer

* readme split

* [GOV] Updated team page (#19)

* Updated team page

* previous devs

* missed one

---------

Co-authored-by: Matthew Middlehurst <m.middlehurst@uea.ac.uk>

* [FORK] Revert #15 "Remove workflow files" (MERGE WHEN REPO PUBLIC) (#16)

* temporarily stop this action

* comment out all github workflows

* revert

* remove workflows

* add workflows

* uncommented

* license update (#56)

* [BUG] Update check_n_jobs (#14)

* check_n_jobs

* check_n_jobs

* min 1 thread

* Added CoCC members (#57)

* [ENH] Dictionary Classifiers (#58)

Maintenance of Dictionary Classifiers
- Reverts alphabet_size=4 for BOSS and WEASEL,
- carries out deprecation of cBOSS
- adds dilation to SFAFast
- Tidies up Doc-Strings

* remove shellcheck (#60)

* add disclaimer (#64)

---------

Co-authored-by: Matthew Middlehurst <pfm15hbu@uea.ac.uk>
Co-authored-by: Matthew Middlehurst <m.middlehurst@uea.ac.uk>
Co-authored-by: Patrick Schäfer <patrick.schaefer@hu-berlin.de>
Co-authored-by: Lukasz Mentel <lmmentel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Contractable BOSS deprecation
2 participants