Address encoding of block.coinbase_account

[graup]

block.coinbase_account should be a b58check encoded address.

Current result: eZDSP5tk3jz49yjxiF2XMkfou3VQtDRxVow1PNPuz3Qe

Expected result: AmLrV7tg69KE5ZQehkjGiA7yJyDxJ25uyF96PMRptfzwozhAJbaK

herapy/aergo/herapy/obj/block.py

Line 203 in 92845d5

"coinbase_account": encode_b58(self.coinbase_account),

[hanlsin]

Hi @graup,

Sorry for late response.

The coinbase account is printing base58.Encode, not base58check.

Where did you find to use base58check for the coinbase account?

https://github.com/aergoio/aergo/blob/35879e34e615f2498a31381ffa97160e98211379/cmd/aergocli/util/base58addr.go#L243

[graup]

@hanlsin Exactly, and that is the problem. It SHOULD be base58check, because it is an address.

[hanlsin]

In that case, it's not only base58check, but also AddressVersion + base58check(addr). Right?

I will report it to Aergo CLI and make it right.

[graup]

More like base58check(addr, AddressVersion), but yes. Thanks

[graup]

Cant you just replace the line with types.EncodeAddress(self.coinbase_account)?

[graup]

Sorry, I misunderstood your previous message. I didn't realize this bug (if I'm right) was also in aergocli. Let's fix it there first!

[hanlsin]

I reported it for aergocli as a question at first, because I don't know the decision about it.

aergoio/aergo#91

And, you are right. Just, in aergocli, replacing

https://github.com/aergoio/aergo/blob/35879e34e615f2498a31381ffa97160e98211379/cmd/aergocli/util/base58addr.go#L243

to out.Header.CoinbaseAccount = types.EncodeAddress(b.GetHeader().GetCoinbaseAccount())

is the simple answer.

[hanlsin]

More like base58check(addr, AddressVersion), but yes. Thanks

Yes. If I may allow to fix it little bit, then it would be base58check(AddressVersion, addr), because the version is in front of the address. :)

[hanlsin]

aergoio/aergo#91

In the issue above, the only base58 expression was mistake. So I will modify herapy for the next release too.

[hanlsin]

It is included in version 1.3.3.