Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass proxy to video-recorder container #392

Closed
toby181 opened this issue Sep 14, 2023 · 2 comments
Closed

pass proxy to video-recorder container #392

toby181 opened this issue Sep 14, 2023 · 2 comments
Milestone

Comments

@toby181
Copy link

toby181 commented Sep 14, 2023

Hi together,

We got moon2, version 2.5.2, running on kubernetes, with video recording enabled.

When the video-recorder container tries to upload the video to a google cloud storage, it does not show any exception, rather the opposite, that it's doing it.

Uploading /home/user/Downloads/video-recording-1.20230914.1340.mp4 to s3://gcp-bucket-1/chrome-112-0-99a42976-c525-4884-af58-0d2528da5ee8/video-recording-1.20230914.1340.mp4

Checking the bucket itself, it's empty.

It seems that the proxy is blocking the request since the proxy settings are missing for the video-recorder container. For the browser container the proxy is passed over.

To verify this assumption I've created an awscli pod with and without proxy.

without proxy (request cancelled, after 1 minute still no response)

I have no name!@tmp-awscli:/$ aws s3 ls s3://gcp-bucket-1 --endpoint-url https://storage.googleapis.com
^C
I have no name!@tmp-awscli:/$ env | grep -i proxy
I have no name!@tmp-awscli:/$ env | grep -i aws
AWS_SECRET_ACCESS_KEY=***
AWS_ACCESS_KEY_ID=***
I have no name!@tmp-awscli:/$

with proxy

I have no name!@tmp-awscli:/$ aws s3 ls s3://gcp-bucket-1 --endpoint-url https://storage.googleapis.com
2023-09-14 13:15:56       3024 export (9).ndjson
I have no name!@tmp-awscli:/$ env | grep -i proxy
NO_PROXY=***
HTTPS_PROXY=http://proxy.example.com:3128
HTTP_PROXY=http://proxy.example.com:3128
I have no name!@tmp-awscli:/$ env | grep -i aws
AWS_SECRET_ACCESS_KEY=***
AWS_ACCESS_KEY_ID=***
I have no name!@tmp-awscli:/$

I've checked the helm chart and the CRDs but could not anything related to this issue. Do I miss something or is that might a missing feature?

@vania-pooh
Copy link
Member

vania-pooh commented Sep 14, 2023

@toby181 so you expect all S3 requests to go through HTTP \ HTTPS proxy, right?

@toby181
Copy link
Author

toby181 commented Sep 15, 2023

@vania-pooh yep, basically that. In my opinion being able to set environment for the video-recorder container via the helmrelease should do the trick.
Unfortunately I don't see an option that I can try this out by somehow manipulating the helm chart. As I mentioned, the only way to proof it, was the awscli pod.

@vania-pooh vania-pooh added this to the 2.6.0 milestone Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants