Add mappers for java.time classes #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reugn
reviewed
Jan 11, 2023
| if (value == null) { | ||
| return null; | ||
| } | ||
| return Date.valueOf((LocalDate) value).getTime(); |
There was a problem hiding this comment.
Suggested change
| return Date.valueOf((LocalDate) value).getTime(); | |
| return ((LocalDate) value).toEpochDay(); |
| return null; | ||
| } | ||
| long longValue = (Long) value; | ||
| return new Date(longValue).toLocalDate(); |
There was a problem hiding this comment.
Suggested change
| return new Date(longValue).toLocalDate(); | |
| return LocalDate.ofEpochDay(longValue); |
| if (value == null) { | ||
| return null; | ||
| } | ||
| return Date.from(((LocalDateTime) value).toInstant(ZoneOffset.UTC)).getTime(); |
There was a problem hiding this comment.
Suggested change
| return Date.from(((LocalDateTime) value).toInstant(ZoneOffset.UTC)).getTime(); | |
| return ((LocalDateTime) value).toInstant(ZoneOffset.UTC).toEpochMilli(); |
- Added a unit test for LocalDateMapper and LocalDateTimeMapper - Changed LocalDateMapper to use EpochDays - Changed LocalDateTimeMapper to preserve full precision of the LocalDateTime down the nanosecond level.
reugn
reviewed
Jan 16, 2023
Added a mapper for LocalTime to round out Java 8 date / time classes. Included a unit test for them.
reugn
changed the title
reugn
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new mapper for Java's LocalDate and LocalDateTime as well as changing the TypeUtils