Map Enums by value fields instead of Enum constant names.

[roimenashe]

• Add enum tests to both reactive and non-reactive flows.

[tfaulkes]

Hey Roi. A couple of comments on this:

In the EnumMapper, your toAerospikeFormat does:

Field enumRequestedField = clazz.getDeclaredField(enumField);
enumRequestedField.setAccessible(true);
return enumRequestedField.get(value).toString();

and fromAerospikeFormat does the converse. This means that 3 introspection calls are done every time we convert the value. The general principle I've tried to adhere to is minimizing introspection calls, and the first 2 are able to be done once when we first see the class which we need to introspect. So I would be inclined to do these 2 in the constructor, but then have addToMap = false in TypeUtils.getMapper so that we don't cache these and hence let different classes uses different short strings. Then you can reduce the number of introspection calls in toAerospikeFormat/fromAerospikeFormat to 1 per call.

The other thought is: I like what you've done here, allowing a lot of flexibility. If there are 2 short names for an enum (eg 2-character country codes and 3-character country codes), the end user can pick and choose. But I would think in most cases the enum itself would know that it wants to use the short name. Can we give the user the option to mark the default Aerospike mapping on the Enum proper as well? So if there are 10 places the same enum is used, we don't have to remember to mark each of them as using the same short field.

[roimenashe]

@tfaulkes
I committed a fix to avoid introspection calls each time we convert (instead I used the constructor as you suggested).

addToMap was already false since I wanted to avoid a situation where caching enum converters of the same enum type but with different @AerospikeEnum annotation field (points to another field) or 1 with annotation and 1 without, in this case it cached the EnumMapper of the first Enum field and use it for the rest of the same enum fields which was a bug (addToMap = false fixed it).

I think giving the user the option to set default enum field to a specific enum (for example, every Country enum usage will be converted to 2 char country code by default) is an advanced feature that I don't see much value in, since we don't want to cache these converters and the annotation is used at the field level, default is to store the constant name and if you want to store a specific field just specify it at the @AerospikeEnum annotation field. it is kind of similar situation as the @AerospikeExclude annotation, let say the user always wants to exclude an email field - it will have to specify @AerospikeExclude at each email field of any object.