Skip to content

[as2_crazyflie_platform] Remove namespace from launch #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

pariaspe
Copy link
Member

Basic Info

Info Please fill out this column
Issue(s) this addresses
ROS2 version tested on Humble
Aerial platform tested on Crazyflie

Description of contribution in a few bullet points

  • Launch namespace was overriding each cf namespace

Namespace was overriding each crazyflie namespace which is intended to be set by swarm_config_file
@pariaspe pariaspe requested a review from RPS98 May 11, 2023 11:37
@codecov-commenter
Copy link

Codecov Report

Merging #239 (2a4f4e3) into main (39e9575) will increase coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 2a4f4e3 differs from pull request most recent head ba533a7. Consider uploading reports for the commit ba533a7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##            main    #239      +/-   ##
========================================
+ Coverage   3.06%   3.14%   +0.07%     
========================================
  Files        100     100              
  Lines       5251    5318      +67     
  Branches     455     480      +25     
========================================
+ Hits         161     167       +6     
- Misses      4952    4990      +38     
- Partials     138     161      +23     
Flag Coverage Δ
unittests 3.14% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RPS98 RPS98 merged commit 346d49f into main May 11, 2023
@RPS98 RPS98 deleted the cf-namespace branch May 11, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants