Skip closing cursor if connection held is no longer active #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It avoids issues when a transaction fails, thus the statement to close the cursor will fail. In addition this obscures the underlying error in the user code due to raising when closing the cursor.
|
@afair Would you consider a release for this please? |
|
Thank you! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It avoids issues when a transaction fails, thus the statement to close the cursor will fail.
In addition this obscures the underlying error in the user code due to raising when closing the cursor.
The tests show a toy case of when/how this can occur, however I've ran into similar issues where I wasn't able to figure out the error from application logs since the error I would get would be the one raised from the
ensureblock.An alternative approach would be to actually nest a begin/rescue in the ensure block and rescue error to avoid obscuring the underlying error, or be more precise and rescue only
ActiveRecord::StatementInvalid. If that is preferred, I could change this PR.