Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于部署的不是 PR 当前分支而是基础分支的问题 #62

Closed
15 of 16 tasks
afc163 opened this issue Nov 11, 2020 · 11 comments
Closed
15 of 16 tasks

关于部署的不是 PR 当前分支而是基础分支的问题 #62

afc163 opened this issue Nov 11, 2020 · 11 comments

Comments

@afc163
Copy link
Owner

afc163 commented Nov 11, 2020 •
edited
Loading

现象见：antvis/antvis.github.io#85 (comment)

解决方式见：#59

需要挨个去发 PR：
This was referenced Nov 11, 2020
Merged
Merged
@xrkffgg
Copy link
Contributor

xrkffgg commented Nov 11, 2020 •
edited
Loading

pro-components
我改过了 ant-design/pro-components@fb2245e

ant-design-colorful 也改过了
ant-design-colorful/ant-design-colorful@10665b3

@afc163 afc163 mentioned this issue Nov 11, 2020
Merged
@xrkffgg
Copy link
Contributor

xrkffgg commented Nov 11, 2020 •
edited
Loading

This was referenced Nov 11, 2020
Merged
Merged
@afc163 afc163 mentioned this issue Nov 11, 2020
Merged
This was referenced Nov 11, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@afc163 afc163 mentioned this issue Nov 18, 2020
Merged
@xrkffgg
Copy link
Contributor

xrkffgg commented Nov 30, 2020

还剩一个，我再提醒下去

@afc163 afc163 mentioned this issue Dec 2, 2020
Merged
@xrkffgg
Copy link
Contributor

xrkffgg commented Jan 18, 2021

最后一个 终于有反应了。。。

@afc163
Copy link
Owner Author

afc163 commented Jan 23, 2021 •
edited
Loading

先回滚到 pull_request 再找别的办法，上面的都要 revert 一遍。

antvis/G2#3080 这个解法貌似可行。

@xrkffgg
Copy link
Contributor

xrkffgg commented Jan 23, 2021

用 g2 的办法吗？

@afc163
Copy link
Owner Author

afc163 commented Jan 23, 2021 •
edited
Loading

G2 实现也有问题，没找到 PR number，要传过去：https://github.com/antvis/G2/runs/1752970333?check_suite_focus=true

@xrkffgg
Copy link
Contributor

xrkffgg commented Jan 23, 2021

那我先把这些回滚到 pull_request ？

@afc163
Copy link
Owner Author

afc163 commented Feb 3, 2021 •
edited
Loading

@xrkffgg 都回滚一下吧。didi/mand-mobile#726

@xrkffgg
Copy link
Contributor

xrkffgg commented Feb 3, 2021 •
edited
Loading

Revert

@afc163
Copy link
Owner Author

afc163 commented Feb 3, 2021

PR 内容里提醒一下是安全原因。

@afc163 afc163 closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afc163 @xrkffgg