Skip to content

Conversation

guillem-211
Copy link
Contributor

Description

🛠️ Changes being made

Please include a summary of the changes and the related issue/feature.

Please also include relevant motivation and context. List any dependencies that are required for this change (e.g. other services involved)

🔬 Test Plan

How do you know the changes are safe to ship?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

🎫 Asanaticket

  • Is the PR attached to the Asanaticket

If there is no Asanaticket for the PR, please describe in 1-2 sentences why there is no ticket for the purposed changes.

🛫 Quality Check

Please delete options that are not relevant!

  • I have performed a self-review of my code

  • I have added tests that prove my fix is effective or that my feature works

  • Do we need to implement analytics?

  • Authorization enabled?

  • Do we have monitoring enabled?

  • Is the Postman collection up-to-date.

  • Readme of the Repo updated.

  • This change requires a documentation update

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • Is the architecture diagram updated.

@guillem-211 guillem-211 requested review from CodeBooster97 and removed request for CodeBooster97 January 16, 2025 11:59
Copy link

qlty-cloud-legacy bot commented Jan 16, 2025

Code Climate has analyzed commit 5eb08ec and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.3% (-0.2% change).

View more on Code Climate.

@guillem-211 guillem-211 changed the title version poetry adding loudness settings to sdk Jan 16, 2025
Copy link
Contributor

@DavideBusacca DavideBusacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me but make sure changelog and poetry version match

pyproject.toml Outdated
@@ -1,6 +1,6 @@
[tool.poetry]
name = "audiostack"
version = "2.7.1"
version = "2.8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.7.2 or 2.8.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do im still working on this :D

@guillem-211 guillem-211 merged commit afa2cdd into main Jan 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants