Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the dependencies, mainly webpack and react #641

Closed
vincentfretin opened this issue Oct 6, 2022 · 3 comments · Fixed by #647
Closed

Update all the dependencies, mainly webpack and react #641

vincentfretin opened this issue Oct 6, 2022 · 3 comments · Fixed by #647

Comments

@vincentfretin
Copy link
Contributor

I have a version of the inspector working with react 18.2.0, mainly changes about string refs that needs to be replaced by React.createRef, and componentWillReceiveProps by componentDidUpdate or getDerivedStateFromProps.
I'm waiting for #638 and #639 to be merged first, then I can proceed updating webpack to version 5, babel, react and other dependencies.

This will fix #606

@vincentfretin
Copy link
Contributor Author

This will replace the PR #601

@vincentfretin
Copy link
Contributor Author

For reference, the repo currently uses react 15.6.2.

@vincentfretin
Copy link
Contributor Author

npm run lint
src/components/components/Mixins.js
  20:5  error  Do not use setState in componentDidUpdate  react/no-did-update-set-state

=> modify it to use getDerivedStateFromProps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant