-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 0 Toggle panels shortcut not properly working #648
Conversation
…ditor is reenabled
There is no reason to call The feature of showing again the panels is a little bit broken. |
There was a third issue where clicking the "+" for a panel reset the visibility to false (undefined really) of the other panel. |
src/style/index.styl
Outdated
left 0 | ||
|
||
.toggle-sidebar.right | ||
right 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous rule matched element with "right" class as a child of element having "toggle-sidebar" class. This is not what we want here. The div has both the "toggle-sidebar" and "right" classes, so we want a ".toggle-sidebar.right" rule without space. If you put a space, it means the same as the previous rule.
Oh, the "+" buttons actually never show up if you test with |
This PR can actually be merged only after we update the babel stack that I did in #641 because I used the spread syntax here
but you can review it already. |
The commit a00448b also fixes issues with the delete modal. The issues was the following: |
I replaced the spread syntax by
|
@dmarcos can you please merge those changes? |
I approve this message! To add more detail, I am trying to make updates to the 3dstreet editor that match close enough with @vincentfretin that we can also push improvements back to this repo. I am trusting that Vincent can help guide us through improving the inspector for all while also enabling neat community modules that we're all working on and would like to share |
@dmarcos the inspector is one of the buggiest problem areas of a-frame, it would be really great to have these fixes in and to encourage the development of this side of the project! |
When disabling the editor and enabling it again via the
Back to scene
followed byInspect scene
button, the0 Toggle panels
shortcut wasn't properly working one time over two. This was because the listeners was added a second time, a third time, forth time... so removing the listeners indisable()
wasn't working properly.this.onKeyDown
,this.onKeyUp
are already bound in init.The function given to addEventListener in
enable()
and removeEventListener indisable()
needs to be the same.