-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some UI issues #638
Fix some UI issues #638
Conversation
I think it doesn't need rebase. does it? |
If you want to merge it right away, yeah it doesn't need a rebase. |
d3a3479
to
14cccbb
Compare
I rebased in case you want to test the branch first before merging. |
Once this is merged, please run |
I have a
|
I'm currently testing with aframe master threejs r144 with a tailwindcss theme. The latest commit I did fixes the error update method undefined because I had an avatar with SkinnedMesh in my scene. |
I did some cleanup in the files in the lib folder because I'm reusing all those files but with my own ui in a project, so I went ahead and contributed it here too. I think you can merge now, those are really small changes. Are you interested in more heavy updates, update the webpack stack, run prettier on the files again, remove the eslint rules concerning the style, integrate husky to run prettier on the files, update to latest react and api, use only import/export everywhere and not a mix of import and require. Will you merge it? |
2010867
to
e5d2eaa
Compare
I moved the code cleanup I'm currently doing in #639 so you can concentrate on the functional issues I fixed in this PR. Do you have any comment on the things I fixed here? |
Another UI issue fixed in #648 |
The |
…nt set via a mixin for shortOrange entity)
…try in three r144)
19b240b
to
8dc8228
Compare
Thank you! |
…lapsible behavior in another way
…apsible behavior in another way
Needs to be rebased after #637 is merged, the branch won't work if you're trying to test it