Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove redundant removeObject call, this is already called on child-detached #752

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

vincentfretin
Copy link
Contributor

Remove redundant removeObject call that removes helpers, this is already called on child-detached event.
This was called a second time when removeChild was called because of the listener here

document.addEventListener('child-detached', (event) => {
var entity = event.detail.el;
AFRAME.INSPECTOR.removeObject(entity.object3D);
});

@dmarcos
Copy link
Member

dmarcos commented Aug 29, 2024

Thank you!

@dmarcos dmarcos merged commit 1101fbe into aframevr:master Aug 29, 2024
1 check passed
@vincentfretin vincentfretin deleted the removeObject-call-redundant branch August 30, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants