Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples using templates are busted (especially in Chrome) #828

Closed
cvan opened this issue Jan 14, 2016 · 5 comments
Closed

Examples using templates are busted (especially in Chrome) #828

cvan opened this issue Jan 14, 2016 · 5 comments

Comments

@cvan
Copy link
Contributor

cvan commented Jan 14, 2016

All examples that use templates now have camera issues; I see this error in Chrome but not in Firefox:

THREE.WebGLRenderer.render: camera is not an instance of THREE.Camera.

Anime UI in Chrome vs Firefox:

screenshot 2016-01-13 17 01 26
screenshot 2016-01-13 17 02 54

The Spheres & Fog example doesn't have any camera errors but also appears quite busted in Chrome:

screenshot 2016-01-13 16 55 54


This must be related to a recent aframe-core change and now since the merge it's become apparent. Perhaps related to #794?

@cvan cvan changed the title Examples with templates busted in Chrome Examples using templates are busted (especially in Chrome) Jan 21, 2016
@cvan
Copy link
Contributor Author

cvan commented Jan 21, 2016

This is due to a change with the loading process that was upstreamed in the aframe-core -> aframe merge. @ngokevin is revisiting the Primitives work I started by extending <a-entity> so we don't have to worry about load order. This will still pose a problem for folks who ever use templates (or even just injecting inert objects into the scene that aren't registered custom elements of <a-entity> yet) - so we'll need to fix the core of the issue later.

@cvan
Copy link
Contributor Author

cvan commented Jan 21, 2016

So note to everyone: just use entities everywhere for the time being.

@cvan
Copy link
Contributor Author

cvan commented Feb 5, 2016

this has been magically fixed by #776. so if we actually wanted to, we could keep templates in their current form. but I'm comfortable with removing them until we've confident we need them (see issue #930).

@cvan cvan closed this as completed Feb 5, 2016
@ngokevin
Copy link
Member

ngokevin commented Feb 5, 2016

Examples using templates mostly still not working.

@ngokevin
Copy link
Member

#883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants