-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bundled homomorphisms #2383
base: master
Are you sure you want to change the base?
Conversation
Before I look at this at all I just want to say thanks for tackling it! I've been avoiding it with the hope that we can get a solution for #2287, but that looks a long way off. |
@Taneb Indeed! This kind of boilerplate-bashing is quite fatiguing, until you run up against the 'diamond' re-export problem, at which point my powers fail me in different ways, trying to work out what should get re-exported from where... plus discovering that (still!) not everything is present which perhaps ought to be... ;-) UPDATED: moving to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems quite reasonable. I am doing this as a comment because it seems incomplete - but I have no specific improvement that I'd like to see in the code that is here.
@JacquesCarette @Taneb I have now added the 'missing' parts of the PR (as in the revised opening preamble above), and so (hopefully) now stopping there... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following don't need changes now but we should make issues for them so we don't lose track:
- Bundles for monomorphisms and isomorphisms (and epimorphisms if we add those) Add bundled mono-/iso-{/epi-} morphisms #2387
- Bundles for lattice-like and module-like morphisms Add bundles for lattice-like and module-like morphisms #2388
Currently badged as v2.2, but could merge for v2.1? |
Have now updated the UPDATED: pending resolution of this issue, PR is now up-to-date and ready-to-merge. @MatthewDaggitt are you happy that your review comments have been addressed? |
I think it's fine that they take the full bundles for now. |
Cherry-picked and enhanced from #1962 . Fixes #1960 .
TODO:
Algebra.Morphism.Construct.{Identity|Composition}
materialRingWithoutOne
doesn't appear to export its ownRaw
substructure, so that should be added? ditto.KleeneAlgebra
Structures
/Bundles
NB
Setoid
structure onHom
s at all... (brain-fade; sigh)Semiring
andRing
homomorphisms should export aSuccessorSetHomomorphism
structure/bundleonly after going back to Literals for any ring? #1363 through the medium of (the initial)
SuccessorSet
and its consequences forAlgebra.Structures
having(Is)SuccessorSet
fields...